drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Wed, 13 Sep 2017 18:01:22 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r138694085
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java ---
    @@ -56,7 +56,7 @@ public void checkChangedColumn() throws Exception {
         test("ALTER session SET `%s` = %d;", SLICE_TARGET,
           ExecConstants.SLICE_TARGET_DEFAULT);
         testBuilder()
    -        .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND type = 'SESSION'",
SLICE_TARGET)
    +        .sqlQuery("SELECT status FROM sys.options WHERE name = '%s' AND optionScope =
'SESSION'", SLICE_TARGET)
    --- End diff --
    
    Sounds good. Thanks.


---

Mime
View raw message