drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories
Date Tue, 12 Sep 2017 21:50:46 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/940#discussion_r138472834
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
    @@ -54,11 +56,13 @@
     import org.junit.Ignore;
     import org.junit.Rule;
     import org.junit.Test;
    +import org.junit.experimental.categories.Category;
     import org.junit.rules.TemporaryFolder;
     import org.junit.runner.RunWith;
     import org.junit.runners.Parameterized;
     
     @RunWith(Parameterized.class)
    +@Category({SecondaryTest.class, ParquetTest.class})
    --- End diff --
    
    On the other hand, the Parquet writer seems pretty important and we'd want to test it
more often.
    
    This is why, in my earlier comment, I asked about the purpose of categorization: those
that are worth running frequently ("smoke tests") vs. those that give a more thorough test,
but will typically not find issues.


---

Mime
View raw message