drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories
Date Tue, 12 Sep 2017 21:50:46 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/940#discussion_r138475152
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java ---
    @@ -57,7 +61,9 @@ public static void setUpConnection() throws SQLException {
         // Connection--and other JDBC objects--on test method failure, but this test
         // class uses some objects across methods.)
         Driver.load();
    -    connection = DriverManager.getConnection( "jdbc:drill:zk=local" );
    +    Properties properties = new Properties();
    +    properties.setProperty(OptionValidator.OPTION_DEFAULTS_ROOT + ExecConstants.CREATE_PREPARE_STATEMENT_TIMEOUT_MILLIS,
"30000");
    --- End diff --
    
    Also, since properties don't have to be strings, why is this property stored as a string
when the value is an int?


---

Mime
View raw message