drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories
Date Tue, 12 Sep 2017 21:50:46 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/940#discussion_r138466695
  
    --- Diff: common/src/test/java/org/apache/drill/categories/package-info.java ---
    @@ -0,0 +1,23 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +/**
    + * This package stores the JUnit test categories.
    + */
    --- End diff --
    
    Very cool. One thing that is not intuitively obvious here is the purpose and usage of
the categories.
    
    On the one hand, we already have modules for memory, vectors, Hive, etc. One can easily
run just those tests by cd'ing into that module and running Maven from there.
    
    So, one would imagine categories to provide another dimension, orthogonal to modules.
For example, the classic "fast" vs. "slow." One could also imagine a core set of "smoke" tests
that run quickly and do a quick validation. Then a set of standard tests that are more thorough.
Then, very in-depth tests that either take a long time, or validate very specific bugs or
regressions.
    
    Can you add a bit of commentary to advise how you envision the categories to be used?


---

Mime
View raw message