drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...
Date Tue, 12 Sep 2017 02:42:23 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/938#discussion_r138240616
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -297,10 +302,7 @@ public void outputRecordValues(@Named("htRowIdx") int htRowIdx, @Named("outRowId
       }
     
       @Override
    -  public void setup(HashAggregate hashAggrConfig, HashTableConfig htConfig, FragmentContext
context,
    -                    OperatorStats stats, OperatorContext oContext, RecordBatch incoming,
HashAggBatch outgoing,
    -                    LogicalExpression[] valueExprs, List<TypedFieldId> valueFieldIds,
TypedFieldId[] groupByOutFieldIds,
    -                    VectorContainer outContainer) throws SchemaChangeException, IOException
{
    +  public void setup(HashAggregate hashAggrConfig, HashTableConfig htConfig, FragmentContext
context, OperatorStats stats, OperatorContext oContext, RecordBatch incoming, HashAggBatch
outgoing, LogicalExpression[] valueExprs, List<TypedFieldId> valueFieldIds, TypedFieldId[]
groupByOutFieldIds, VectorContainer outContainer, int extraRowBytes) throws SchemaChangeException,
IOException {
    --- End diff --
    
    Removed one argument "stats" - can be taken from the "oContext"


---

Mime
View raw message