drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Mon, 11 Sep 2017 17:12:14 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r138133105
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java
---
    @@ -216,79 +216,77 @@ public void injectionOnSpecificBit() {
         final ZookeeperHelper zkHelper = new ZookeeperHelper();
         zkHelper.startZookeeper(1);
     
    -    // Creating two drillbits
    -    final Drillbit drillbit1, drillbit2;
    -    final DrillConfig drillConfig = zkHelper.getConfig();
         try {
    -      drillbit1 = Drillbit.start(drillConfig, remoteServiceSet);
    -      drillbit2 = Drillbit.start(drillConfig, remoteServiceSet);
    -    } catch (DrillbitStartupException e) {
    -      throw new RuntimeException("Failed to start drillbits.", e);
    -    }
    +      // Creating two drillbits
    +      final Drillbit drillbit1, drillbit2;
    +      final DrillConfig drillConfig = zkHelper.getConfig();
    +      try {
    +        drillbit1 = Drillbit.start(drillConfig, remoteServiceSet);
    +        drillbit2 = Drillbit.start(drillConfig, remoteServiceSet);
    +      } catch (DrillbitStartupException e) {
    +        throw new RuntimeException("Failed to start drillbits.", e);
    +      }
     
    -    final DrillbitContext drillbitContext1 = drillbit1.getContext();
    -    final DrillbitContext drillbitContext2 = drillbit2.getContext();
    +      final DrillbitContext drillbitContext1 = drillbit1.getContext();
    +      final DrillbitContext drillbitContext2 = drillbit2.getContext();
     
    -    final UserSession session = UserSession.Builder.newBuilder()
    -        .withCredentials(UserBitShared.UserCredentials.newBuilder().setUserName("foo").build())
    -        .withUserProperties(UserProperties.getDefaultInstance())
    -        .withOptionManager(drillbitContext1.getOptionManager())
    -        .build();
    +      final UserSession session = UserSession.Builder.newBuilder().withCredentials(UserBitShared.UserCredentials.newBuilder().setUserName("foo").build()).withUserProperties(UserProperties.getDefaultInstance()).withOptionManager(drillbitContext1.getOptionManager()).build();
    --- End diff --
    
    I'm a victim of autoformat. Fixed.


---

Mime
View raw message