drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #937: DRILL-5002: Using hive's date functions on top of d...
Date Sun, 10 Sep 2017 01:46:15 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/937#discussion_r137938539
  
    --- Diff: contrib/storage-hive/core/src/main/codegen/templates/ObjectInspectorHelper.java
---
    @@ -204,7 +204,11 @@ public static JBlock getDrillObject(JCodeModel m, ObjectInspector
oi,
               <#elseif entry.hiveType == "TIMESTAMP">
                 JVar tsVar = jc._else().decl(m.directClass(java.sql.Timestamp.class.getCanonicalName()),
"ts",
                   castedOI.invoke("getPrimitiveJavaObject").arg(returnValue));
    -            jc._else().assign(returnValueHolder.ref("value"), tsVar.invoke("getTime"));
    +            // Bringing relative timestamp value without timezone info to timestamp value
in UTC, since Drill keeps date-time values in UTC
    --- End diff --
    
    Drill does not actually keep values in UTC: Drill keeps values in the server time zone.
This is why Drill dates, when shipped to a client with a different time zone, get corrupted.


---

Mime
View raw message