drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Sun, 10 Sep 2017 00:33:32 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r137937392
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
---
    @@ -63,32 +88,32 @@
       public final Double float_val;
       public final OptionScope scope;
     
    -  public static OptionValue createLong(OptionType type, String name, long val, OptionScope
scope) {
    +  public static OptionValue create(OptionType type, String name, long val, OptionScope
scope) {
         return new OptionValue(Kind.LONG, type, name, val, null, null, null, scope);
       }
     
    -  public static OptionValue createBoolean(OptionType type, String name, boolean bool,
OptionScope scope) {
    +  public static OptionValue create(OptionType type, String name, boolean bool, OptionScope
scope) {
         return new OptionValue(Kind.BOOLEAN, type, name, null, null, bool, null, scope);
       }
     
    -  public static OptionValue createString(OptionType type, String name, String val, OptionScope
scope) {
    +  public static OptionValue create(OptionType type, String name, String val, OptionScope
scope) {
         return new OptionValue(Kind.STRING, type, name, null, val, null, null, scope);
       }
     
    -  public static OptionValue createDouble(OptionType type, String name, double val, OptionScope
scope) {
    +  public static OptionValue create(OptionType type, String name, double val, OptionScope
scope) {
         return new OptionValue(Kind.DOUBLE, type, name, null, null, null, val, scope);
       }
     
    -  public static OptionValue createOption(Kind kind, OptionType type, String name, String
val, OptionScope scope) {
    +  public static OptionValue create(Kind kind, OptionType type, String name, String val,
OptionScope scope) {
    --- End diff --
    
    Per earlier comment, `String val` --> `Object val`, with casts rather than string conversions
below?


---

Mime
View raw message