drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Tue, 05 Sep 2017 21:44:11 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r137122952
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -83,18 +86,20 @@
       @VisibleForTesting
       public Drillbit(
           final DrillConfig config,
    +      final CaseInsensitiveMap<OptionValidator> validators,
           final RemoteServiceSet serviceSet) throws Exception {
    -    this(config, serviceSet, ClassPathScanner.fromPrescan(config));
    +    this(config, validators, serviceSet, ClassPathScanner.fromPrescan(config));
    --- End diff --
    
    Currently there are no internal validators defined, so in order to test the logic for
internal validators I had to create a set of mock validators which included internal validators,
and use those for testing. I have changed this so that the Drillbit constructors which take
a set of validators are annotated to be visible for testing.


---

Mime
View raw message