drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From weijietong <...@git.apache.org>
Subject [GitHub] drill issue #904: DRILL-5717: change some date time test cases with specific...
Date Sun, 03 Sep 2017 14:42:35 GMT
Github user weijietong commented on the issue:

    https://github.com/apache/drill/pull/904
  
    @vvysotskyi has updated the mentioned parts. These [4ea36c3](https://github.com/apache/drill/commit/4ea36c3f18841b229aca5048b7d162ea16bfd5a1),
[caa8b78](https://github.com/apache/drill/commit/caa8b78c5c31c44e59b5ff1bdf6f1900d14b1a1a)
two links has been deeply thought about . I think they can't be solved using the same approach
at current PR. They are too old to lost some function definitions like `casttimestamptz` .
`VectorUtil.appendVectorAccessibleContent` 's date format does not retain time zone part.
 So I suggest they should be kept there or removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message