drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #928: DRILL-5716: Queue-driven memory allocation
Date Fri, 01 Sep 2017 21:50:43 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/928#discussion_r136665632
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
---
    @@ -186,9 +187,10 @@ public void dispose(WebUserConnection instance) {
         @Inject
         WorkManager workManager;
     
    +    @SuppressWarnings("resource")
         @Override
         public WebUserConnection provide() {
    -      final HttpSession session = request.getSession();
    +//      final HttpSession session = request.getSession();
    --- End diff --
    
    Overabundance of caution? But, since nothing broke when I commented out the line, I've
gone ahead and deleted it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message