drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Fri, 01 Sep 2017 21:37:01 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r136669723
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
    @@ -70,11 +69,13 @@
      *  </p>
      */
     
    -public class SystemOptionManager extends BaseOptionManager implements OptionManager,
AutoCloseable {
    +public class SystemOptionManager extends BaseOptionManager implements AutoCloseable {
       private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(SystemOptionManager.class);
     
    -  private CaseInsensitiveMap<OptionValidator> VALIDATORS;
    -  public void populateValidators() {
    +  public static final CaseInsensitiveMap<OptionValidator> DEFAULT_VALIDATORS =
    --- End diff --
    
    I don't completely follow this. Let's talk about this offline next week so that I can
understand :). I can post the conclusion of the discussion on the PR for the community then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message