drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Fri, 01 Sep 2017 20:54:53 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r136660399
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -83,18 +86,20 @@
       @VisibleForTesting
       public Drillbit(
           final DrillConfig config,
    +      final CaseInsensitiveMap<OptionValidator> validators,
           final RemoteServiceSet serviceSet) throws Exception {
    -    this(config, serviceSet, ClassPathScanner.fromPrescan(config));
    +    this(config, validators, serviceSet, ClassPathScanner.fromPrescan(config));
    --- End diff --
    
    Interesting... Why was this change needed?
    
    To be honest, I'm not convinced that the set of inputs is an *input* to the Drillbit rather
than an internal *attribute* of the Drillbit. That is, the Drillbit should be responsible
for defining its set of valid options, not the code that houses the Drillbit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message