drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...
Date Fri, 01 Sep 2017 20:54:33 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r136658551
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/OptionIterator.java
---
    @@ -36,7 +36,7 @@
     //  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(OptionIterator.class);
     
       enum Mode {
    -    BOOT, SYS_SESS, BOTH
    +    BOOT, SYS_SESS_EXTERNAL, SYS_SESS_INTERNAL, BOTH
    --- End diff --
    
    Can we improve these names? Maybe `RUNTIME` for system/session option.
    
    I'm not clear on the distinction between external and internal. Do we mean something like
public and internal?
    
    Does the external mean only public, while internal means public and private?
    
    And, given that we have three options, `BOTH` seems a bit of a misnomer...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message