drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #928: Drill 5716: Queue-driven memory allocation
Date Fri, 01 Sep 2017 05:37:03 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/928#discussion_r136333709
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -394,6 +394,8 @@
     
       DoubleValidator QUEUE_MEMORY_RATIO = new RangeDoubleValidator("exec.queue.memory_ratio",
0.001, 1000);
     
    +  DoubleValidator QUEUE_MEMORY_RESERVE = new RangeDoubleValidator("exec.queue.memory_reserve_ratio",
0, 1.0);
    --- End diff --
    
    please add a comment explaining what this ratio means as you mentioned in the commit notes.
Please do for the queue.memory_ratio as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message