drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #928: Drill 5716: Queue-driven memory allocation
Date Fri, 01 Sep 2017 05:36:43 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/928#discussion_r136450731
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -344,6 +357,20 @@ drill.exec: {
       # Full workspace name should be indicated (including schema and workspace separated
by dot).
       # Workspace MUST be file-based and writable. Workspace name is case-sensitive.
       default_temporary_workspace: "dfs.tmp"
    +
    +  // Resource management
    +  rm : {
    +    // Memory per node normally comes from the direct memory alloated on the JVM
    +    // command line. This parameter, if other than 0, further limits the amount.
    +    // Primarily for testing.
    +    memory_per_node: 0,
    +    // The number of available CPUs normally comes directly from the system itself.
    +    // This parameter, if other than 0, further limits the number of CPUs will
    +    // will consider when planning. Note that, sadly, this parameter does not
    +    // limit *actual* CPU usage; only the amount of CPU assumed to exist when
    +    // planning and managing queries. Primarily for testing.
    +    cpus_per_node: 0,
    +  }
    --- End diff --
    
    I am wondering should we have some prefix like memory_per_node_for_testing_only or memory_per_node_debug_only
so someone will not misinterpret or accidentally change this config and expect different results.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message