Return-Path: <dev-return-31164-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DB852200CF1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 28 Aug 2017 19:20:10 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id DA22D16537E; Mon, 28 Aug 2017 17:20:10 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5295E16537F
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 28 Aug 2017 19:20:10 +0200 (CEST)
Received: (qmail 88080 invoked by uid 500); 28 Aug 2017 17:20:08 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 84601 invoked by uid 99); 28 Aug 2017 17:20:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2017 17:20:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 2732FF5EDC; Mon, 28 Aug 2017 17:20:03 +0000 (UTC)
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-906-drill@git.apache.org>
In-Reply-To: <git-pr-906-drill@git.apache.org>
Subject: [GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...
Content-Type: text/plain
Message-Id: <20170828172003.2732FF5EDC@git1-us-west.apache.org>
Date: Mon, 28 Aug 2017 17:20:03 +0000 (UTC)
archived-at: Mon, 28 Aug 2017 17:20:11 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/906#discussion_r135574741
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java ---
    @@ -160,12 +161,7 @@ public RelOptCost computeSelfCost(final RelOptPlanner planner, RelMetadataQuery
         final ScanStats stats = groupScan.getScanStats(settings);
         int columnCount = getRowType().getFieldCount();
         double ioCost = 0;
    -    boolean isStarQuery = Iterables.tryFind(getRowType().getFieldNames(), new Predicate<String>() {
    -      @Override
    -      public boolean apply(String input) {
    -        return Preconditions.checkNotNull(input).equals("*");
    -      }
    -    }).isPresent();
    +    boolean isStarQuery = AbstractRecordReader.isStarQuery(columns);
    --- End diff --
    
    Should this planning-time class depend on a specific execution-time class? Or, would it be better to move the method from the execution class onto something common between plan and execution?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---