Return-Path: <dev-return-31145-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 76073200D04
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 28 Aug 2017 06:00:36 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 74857163A81; Mon, 28 Aug 2017 04:00:36 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id CCC98163A80
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 28 Aug 2017 06:00:35 +0200 (CEST)
Received: (qmail 39790 invoked by uid 500); 28 Aug 2017 04:00:34 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 39779 invoked by uid 99); 28 Aug 2017 04:00:34 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2017 04:00:34 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id AAF2EF16B2; Mon, 28 Aug 2017 04:00:33 +0000 (UTC)
From: sohami <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-910-drill@git.apache.org>
In-Reply-To: <git-pr-910-drill@git.apache.org>
Subject: [GitHub] drill pull request #910: DRILL-5726: Support Impersonation without authentic...
Content-Type: text/plain
Message-Id: <20170828040033.AAF2EF16B2@git1-us-west.apache.org>
Date: Mon, 28 Aug 2017 04:00:33 +0000 (UTC)
archived-at: Mon, 28 Aug 2017 04:00:36 -0000

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/910#discussion_r135438164
  
    --- Diff: exec/java-exec/src/main/resources/rest/query/query.ftl ---
    @@ -47,8 +58,32 @@
           <label for="query">Query</label>
           <textarea class="form-control" id="query" rows="5" name="query" style="font-family: Courier;"></textarea>
         </div>
    -    <button type="submit" class="btn btn-default">Submit</button>
    +
    +    <button class="btn btn-default" type=<#if model?? && model>"button" onclick="doSubmit()"<#else>"submit"</#if>>
    +      Submit
    +    </button>
       </form>
    +
    +    <#if model?? && model>
    +      <script>
    +        function doSubmit() {
    +          var userName = document.getElementById("userName").value;
    +          $.ajax({
    +            type: "POST",
    +            beforeSend: function (request) {
    +              request.setRequestHeader("User-Name", userName);
    +            },
    +            url: "/query",
    +            data: $("#queryForm").serializeArray(),
    +            success: function (response) {
    --- End diff --
    
    Just eager to know what will happen in case of failure since there is no callback provided here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---