Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-907-drill@git.apache.org>
In-Reply-To: <git-pr-907-drill@git.apache.org>
Subject: [GitHub] drill pull request #907: DRILL-5697: Improve performance of filter operator ...
Content-Type: text/plain
Message-Id: <20170818191753.E72E8F3328@git1-us-west.apache.org>
Date: Fri, 18 Aug 2017 19:17:53 +0000 (UTC)
archived-at: Fri, 18 Aug 2017 19:17:57 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/907#discussion_r134032943
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/RegexpUtil.java ---
    @@ -96,20 +145,46 @@ public static String sqlToRegexLike(
                 || (nextChar == '%')
                 || (nextChar == escapeChar)) {
               javaPattern.append(nextChar);
    +          simplePattern.append(nextChar);
               i++;
             } else {
               throw invalidEscapeSequence(sqlPattern, i);
             }
           } else if (c == '_') {
    +        // if we find _, it is not simple pattern, we are looking for only %
    +        notSimple = true;
    --- End diff --
    
    `type = NOT_SIMPLE`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---