drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots
Date Thu, 17 Aug 2017 15:19:09 GMT
GitHub user vvysotskyi opened a pull request:

    https://github.com/apache/drill/pull/909

    DRILL-4264: Allow field names to include dots

    1. Removed checking the field name for dots.
    2. Replaced using `SchemaPath.getAsUnescapedPath()` method by `SchemaPath.getRootSegmentPath()`
and `SchemaPathUtil.getMaterializedFieldFromSchemaPath()` where it is needed. 
    3. Replaced using `MaterializedField.getPath()` and `MaterializedField.getLastName()`
methods by `MaterializedField.getName()` method and checked the correctness of the behaviour.
    4. Added tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vvysotskyi/drill DRILL-4264

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
    
----
commit 4ba59488a96fb79455b192ed960a728481ceaf93
Author: Volodymyr Vysotskyi <vvovyk@gmail.com>
Date:   2017-07-05T19:08:59Z

    DRILL-4264: Allow field names to include dots

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message