drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arina Yelchiyeva <arina.yelchiy...@gmail.com>
Subject Re: Webui and absolute links
Date Mon, 07 Aug 2017 13:38:33 GMT
Hi Jorg,

can you please first create Drill Jira and describe the problem there and
then link it to your PR?

Kind regards
Arina

On Mon, Aug 7, 2017 at 4:28 AM, Jörg Schad <joerg@mesosphere.io> wrote:

> Maybe code can express my intentions more clearly:
> https://github.com/apache/drill/pull/896
>
> On Sun, Aug 6, 2017 at 5:36 PM, Jörg Schad <joerg@mesosphere.io> wrote:
>
> > Looking at it, it seems to be a separate issue to me.
> >
> > That issue is about external references, I care about the internal links.
> > These currently use absolute addressing at many places, which leads to
> the
> > problem in the DC/OS UI that css files etc cannot be loaded:
> >
> >
> > On Sun, Aug 6, 2017 at 5:28 PM, Pritesh Maker <pmaker@mapr.com> wrote:
> >
> >> Hi
> >>
> >> Could this be a duplicate of this JIRA - DRILL-5699: Drill Web UI Page
> >> Source Has Links To External Sites
> >>
> >> It’s in progress with this PR – https://github.com/apache/
> drill/pull/891
> >>
> >> Pritesh
> >>
> >> On 8/6/17, 4:28 PM, "Jörg Schad" <joerg@mesosphere.io> wrote:
> >>
> >>     Hi,
> >>     I am just creating a drill package for DC/OS / Apache Mesos.
> >>
> >>     The one problem I am facing is the UI integration. Unfortunately the
> >> drill
> >>     UI uses static links (
> >>     e.g.,
> >>     <link rel="shortcut icon" href="/static/img/drill.ico">
> >>     <link href="/static/css/bootstrap.min.css" rel="stylesheet">
> >>     ) .
> >>     This does not work nicely with the DC/OS UI, which would reference
> the
> >>     drill UI via https://<cluster>/service/drill/.
> >>
> >>     Are there any objections against a PR making the all the links
> >> relative (
> >>     e.g.,
> >>     <link rel="shortcut icon" href="./static/img/drill.ico">
> >>     <link href="./static/css/bootstrap.min.css" rel="stylesheet">
> >>     ).
> >>
> >>
> >>     Thank you!
> >>     Joerg
> >>
> >>
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message