drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #927: DRILL-5751: Fix unit tests to use local file system...
Date Thu, 31 Aug 2017 16:36:06 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/927#discussion_r136384386
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/util/FileSystemUtilTestBase.java
---
    @@ -64,7 +63,9 @@
       @BeforeClass
       public static void setup() throws IOException {
         // initialize file system
    -    fs = FileSystem.get(new Configuration());
    +    Configuration configuration = new Configuration();
    +    configuration.set(FileSystem.FS_DEFAULT_NAME_KEY, FileSystem.DEFAULT_FS);
    +    fs = FileSystem.get(configuration);
    --- End diff --
    
    These three lines appear several times in the code, so may be it would be better to create
a static method which returns `FileSystem` instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message