drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #910: DRILL-5726: Support Impersonation without authentic...
Date Mon, 28 Aug 2017 16:48:09 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/resources/rest/query/query.ftl ---
    @@ -21,8 +24,16 @@
         <button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>
         Sample SQL query: <strong>SELECT * FROM cp.`employee.json` LIMIT 20</strong>
    -  <form role="form" action="/query" method="POST">
    -    <div class="form-group">
    +  <#if model?? && model>
    +     <div class="form-group">
    +       <label for="userName">User Name</label>
    +       <input type="text" size="30" name="userName" id="userName" placeholder="User
    --- End diff --
    Done. Did not use `required` attribute since it's not working with `onclick`, instead
check is using js.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message