drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots
Date Wed, 23 Aug 2017 17:29:43 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/909#discussion_r134688368
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
---
    @@ -293,7 +294,7 @@ private StreamingAggregator createAggregatorInternal() throws SchemaChangeExcept
             continue;
           }
           keyExprs[i] = expr;
    -      final MaterializedField outputField = MaterializedField.create(ne.getRef().getAsUnescapedPath(),
expr.getMajorType());
    +      final MaterializedField outputField = SchemaPathUtil.getMaterializedFieldFromSchemaPath(ne.getRef(),
expr.getMajorType());
    --- End diff --
    
    Yes, it should. But `MaterializedField` class is in the `vector` module, `SchemaPath`
class is in the `drill-logical` module and `vector` module does not have the dependency on
the `drill-logical` module.
    Replaced this code by the `MaterializedField.create(ne.getRef().getLastSegment().getNameSegment().getPath(),
expr.getMajorType());` since simple name path is used here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message