drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvysotskyi <...@git.apache.org>
Subject [GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots
Date Wed, 23 Aug 2017 17:29:40 GMT
Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/909#discussion_r134795741
  
    --- Diff: logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
    @@ -115,6 +112,33 @@ public static SchemaPath create(NamePart namePart) {
       }
     
       /**
    +   * Parses input string and returns {@code SchemaPath} instance.
    +   *
    +   * @param expr input string to be parsed
    +   * @return {@code SchemaPath} instance
    +   */
    +  public static SchemaPath parseFromString(String expr) {
    --- End diff --
    
    It parses a string using the same rules which are used for the field in the query. If
a string contains dot outside backticks, or there are no backticks in the string, will be
created `SchemaPath` with the `NameSegment` which contains one else `NameSegment`, etc. If
a string contains [] then `ArraySegment` will be created.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message