drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitblender <...@git.apache.org>
Subject [GitHub] drill pull request #894: DRILL-5701: drill.connections.rpc.<user/control/dat...
Date Tue, 22 Aug 2017 18:02:29 GMT
Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/894#discussion_r134553446
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitKerberos.java
---
    @@ -137,6 +142,41 @@ public Void run() throws Exception {
         test("SELECT * FROM cp.`region.json` LIMIT 5");
       }
     
    +  @Test
    +  public void testUnecryptedConnectionCounter() throws Exception {
    +    final Properties connectionProps = new Properties();
    +    connectionProps.setProperty(DrillProperties.SERVICE_PRINCIPAL, krbHelper.SERVER_PRINCIPAL);
    +    connectionProps.setProperty(DrillProperties.KERBEROS_FROM_SUBJECT, "true");
    +    final Subject clientSubject = JaasKrbUtil.loginUsingKeytab(krbHelper.CLIENT_PRINCIPAL,
    +        krbHelper.clientKeytab.getAbsoluteFile());
    +
    +    Subject.doAs(clientSubject, new PrivilegedExceptionAction<Void>() {
    +      @Override
    +      public Void run() throws Exception {
    +        updateClient(connectionProps);
    +        return null;
    +      }
    +    });
    +
    +    // Run few queries using the new client
    +    testBuilder()
    +        .sqlQuery("SELECT session_user FROM (SELECT * FROM sys.drillbits LIMIT 1)")
    +        .unOrdered()
    +        .baselineColumns("session_user")
    +        .baselineValues(krbHelper.CLIENT_SHORT_NAME)
    +        .go();
    +
    +    // Check encrypted counters value
    --- End diff --
    
    Please explain the logic behind the different count values in the assertion. Same for
other tests as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message