drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #906: DRILL-5546: Handle schema change exception failure ...
Date Mon, 21 Aug 2017 19:54:18 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/906#discussion_r134287754
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Project.java
---
    @@ -46,14 +56,18 @@ public Project(@JsonProperty("exprs") List<NamedExpression>
exprs, @JsonProperty
         return exprs;
       }
     
    +  public boolean isOutputProj() {
    --- End diff --
    
    Maybe a comment to explain the purpose of this attribute? To quote from the PR description:
    
    > Add a new flag 'outputProj' to Project operator, to indicate if Project is for the
query's final output. Such Project is added by TopProjectVisitor, to handle fast NONE when
all the inputs to the query are empty
    and are skipped.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message