drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots
Date Sat, 19 Aug 2017 19:24:52 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/909#discussion_r134098783
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/TupleAccessor.java
---
    @@ -48,9 +48,21 @@
     
         MaterializedField column(int index);
     
    -    MaterializedField column(String name);
    +    /**
    +     * Returns {@code MaterializedField} instance from schema using the name path specified
in param.
    +     *
    +     * @param name full name path of the column in the schema
    +     * @return {@code MaterializedField} instance
    +     */
    +    MaterializedField column(String[] name);
    --- End diff --
    
    This is not right. As explained earlier, a tuple is a specialized map that allows both
name and indexed access, but only to direct children. The name above should never be compound.
Instead, the code must work the hierarchy itself (or we'd need to add a method to do so.)
    
    Note that this has been revised/replaced in PR #914.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message