drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots
Date Sat, 19 Aug 2017 19:24:00 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/909#discussion_r134063880
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/SchemaPathUtil.java
---
    @@ -0,0 +1,59 @@
    +/*
    +* Licensed to the Apache Software Foundation (ASF) under one or more
    +* contributor license agreements.  See the NOTICE file distributed with
    +* this work for additional information regarding copyright ownership.
    +* The ASF licenses this file to you under the Apache License, Version 2.0
    +* (the "License"); you may not use this file except in compliance with
    +* the License.  You may obtain a copy of the License at
    +*
    +* http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing, software
    +* distributed under the License is distributed on an "AS IS" BASIS,
    +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    +* limitations under the License.
    +*/
    +package org.apache.drill.exec.vector.complex;
    +
    +import org.apache.drill.common.expression.PathSegment;
    +import org.apache.drill.common.expression.SchemaPath;
    +import org.apache.drill.common.types.TypeProtos;
    +import org.apache.drill.common.types.Types;
    +import org.apache.drill.exec.record.MaterializedField;
    +
    +public class SchemaPathUtil {
    --- End diff --
    
    Can these simply be static methods on Materialized Field? Can just call the method `create()`
since the argument signatures will make the methods unique.
    
    `SchemaPath` is defined in `common`, which is visible to `vector`, so it is fine for `MaterializedField`
to have visibility to `SchemaPath`.
    
    We would want to make clear that the `MaterializedField` is always for the tail member
of `SchemaPath`. (Or is it? A schema path can refer to an array element...)
    
    If we have a name `a.b.c.d`, would we have need to create maps (or repeated maps) for
`a`, `b`, and `c`, then to create and Int, say, for `d`? Or, is the context such that we aways
have a context so that `b` is always in the context of `a`, etc.?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message