drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #907: DRILL-5697: Improve performance of filter operator ...
Date Fri, 18 Aug 2017 05:49:25 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/907#discussion_r133859377
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/RegexpUtil.java
---
    @@ -47,18 +47,55 @@
           "[:alnum:]", "\\p{Alnum}"
       };
     
    +  // type of pattern string.
    +  public enum sqlPatternType {
    +    STARTS_WITH, // Starts with a constant string followed by any string values (ABC%)
    +    ENDS_WITH, // Ends with a constant string, starts with any string values (%ABC)
    +    CONTAINS, // Contains a constant string, starts and ends with any string values (%ABC%)
    --- End diff --
    
    You should add a pattern of the form 'Starts with a constant, ends with another constant,
and has any string in between'
    (ABC%XYZ)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message