drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...
Date Tue, 15 Aug 2017 12:20:23 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r133159772
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -268,11 +276,15 @@ private FileSelection expandIfNecessary(FileSelection selection)
throws IOExcept
         // use the cacheFileRoot if provided (e.g after partition pruning)
         Path metaFilePath = new Path(cacheFileRoot != null ? cacheFileRoot : selectionRoot,
Metadata.METADATA_FILENAME);
         if (!fs.exists(metaFilePath)) { // no metadata cache
    +      MetadataContext metaContext = selection.getMetaContext();
    --- End diff --
    
    Started using metadata context as a ParquetGroupScan field.
    The complexity was with initializing entries with selection root. There was a check when
metadata context is  null. The fact that it was not null only in case, when metadata directories
file is present and using (in that case metadata context was created).
    Added method with javadoc explaining in what cases entries are set as selection root.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message