drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...
Date Thu, 10 Aug 2017 10:21:18 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r132414323
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -209,9 +211,10 @@ public ParquetGroupScan( //
         this.entries = Lists.newArrayList();
         if (fileSelection.getMetaContext() != null &&
             (fileSelection.getMetaContext().getPruneStatus() == PruneStatus.NOT_STARTED ||
    -          fileSelection.getMetaContext().getPruneStatus() == PruneStatus.NOT_PRUNED))
{
    -      // if pruning was not applicable or was attempted and nothing was pruned, initialize
the
    -      // entries with just the selection root instead of the fully expanded list to reduce
overhead.
    +          fileSelection.getMetaContext().getPruneStatus() == PruneStatus.NOT_PRUNED ||
    +            fileSelection.getMetaContext().isMetadataFilesMissingOrCorrupted)) {
    --- End diff --
    
    There are 4 checks in `if` statement, may be we can factor out them in separate method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message