drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Date Mon, 07 Aug 2017 20:17:28 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
    @@ -68,7 +69,7 @@ public void testJaninoClassCompiler() throws Exception {
       public void testJDKClassCompiler() throws Exception {
         logger.debug("Testing JDKClassCompiler");
    -    sessionOptions.setOption(OptionValue.createString(OptionType.SESSION, ClassCompilerSelector.JAVA_COMPILER_OPTION,
    +    sessionOptions.setOption(OptionValue.createString(OptionType.SESSION, ClassCompilerSelector.JAVA_COMPILER_OPTION,
ClassCompilerSelector.CompilerPolicy.JDK.name(), OptionScope.SESSION));
    --- End diff --
    Look like the original API is lacking a nice, simple `set(name, value)` method... Let's
leave that as a project for later.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message