drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dvjyothsna <...@git.apache.org>
Subject [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Date Mon, 07 Aug 2017 17:16:37 GMT
Github user dvjyothsna commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r131712468
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
---
    @@ -68,7 +69,7 @@ public void testJaninoClassCompiler() throws Exception {
       @Test
       public void testJDKClassCompiler() throws Exception {
         logger.debug("Testing JDKClassCompiler");
    -    sessionOptions.setOption(OptionValue.createString(OptionType.SESSION, ClassCompilerSelector.JAVA_COMPILER_OPTION,
ClassCompilerSelector.CompilerPolicy.JDK.name()));
    +    sessionOptions.setOption(OptionValue.createString(OptionType.SESSION, ClassCompilerSelector.JAVA_COMPILER_OPTION,
ClassCompilerSelector.CompilerPolicy.JDK.name(), OptionScope.SESSION));
    --- End diff --
    
    Fallback option manager actually implements setOption and session option manager which
is a subclass of the fallback option managerdoesn't override that. Moreover, we are creating
the option value and passing it. So we need to have a new method to set option in session
option manager. Or can we have a variable "type" and set it to OptionType and set it ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message