drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #874: DRILL-5663: Drillbit fails to start when only keyst...
Date Mon, 07 Aug 2017 16:37:13 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/874#discussion_r131703561
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -122,10 +122,10 @@
       String HTTP_SESSION_MEMORY_RESERVATION = "drill.exec.http.session.memory.reservation";
       String HTTP_SESSION_MEMORY_MAXIMUM = "drill.exec.http.session.memory.maximum";
       String HTTP_SESSION_MAX_IDLE_SECS = "drill.exec.http.session_max_idle_secs";
    -  String HTTP_KEYSTORE_PATH = "javax.net.ssl.keyStore";
    --- End diff --
    
    Hmm, not entirely convinced, but I'm fine as long as you have provided backward compatibility
for existing users.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message