drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill issue #889: DRILL-5691: enhance scalar sub queries checking for the ca...
Date Wed, 02 Aug 2017 10:29:26 GMT
Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/889
  
    @weijietong thanks for the PR.
    1. Is it possible to add unit tests?
    2. Can you please add in method description that a table scan with only one row should
also be considered as a scalar as well.
    3. Please fix indention in `if` statements and change `currentrel` to camel case [1].
    
    [1] https://drill.apache.org/docs/apache-drill-contribution-guidelines/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message