Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-868-drill@git.apache.org>
In-Reply-To: <git-pr-868-drill@git.apache.org>
Subject: [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Content-Type: text/plain
Message-Id: <20170728212711.25310F3313@git1-us-west.apache.org>
Date: Fri, 28 Jul 2017 21:27:11 +0000 (UTC)
archived-at: Fri, 28 Jul 2017 21:27:17 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r130187546
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/ExtendedOptionIterator.java ---
    @@ -0,0 +1,142 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.sys;
    +
    +import java.util.Collections;
    +import java.util.Comparator;
    +import java.util.HashMap;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Map;
    +
    +
    +import com.google.common.collect.Lists;
    +import org.apache.drill.exec.ops.FragmentContext;
    +import org.apache.drill.exec.server.options.OptionManager;
    +import org.apache.drill.exec.server.options.OptionValue;
    +import org.apache.drill.exec.server.options.OptionValue.Kind;
    +import org.apache.drill.exec.server.options.OptionValue.OptionType;
    +import org.apache.drill.exec.server.options.OptionValue.OptionScope;
    +
    +
    +/*
    + * To extend the original Option iterator to hide the implementation details and to return the row
    + * which takes precedence over others for an option.This is done by examining the type as the precendence
    + * order is session - system - default.All the values are represented as String instead of having multiple
    + * columns and the datatype is provided for type details.
    --- End diff --
    
    Maybe provide an example:
    foo, bar, mumble
    "fred", 10, SESSION
    With the "foo" etc. replaced with actual column names...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---