Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 15919200CED for ; Fri, 14 Jul 2017 00:21:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 13EF916CFF4; Thu, 13 Jul 2017 22:21:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 53ECF16CFEC for ; Fri, 14 Jul 2017 00:21:20 +0200 (CEST) Received: (qmail 54614 invoked by uid 500); 13 Jul 2017 22:21:17 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 53756 invoked by uid 99); 13 Jul 2017 22:21:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2017 22:21:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 248FCF550C; Thu, 13 Jul 2017 22:21:17 +0000 (UTC) From: Ben-Zvi To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro... Content-Type: text/plain Message-Id: <20170713222117.248FCF550C@git1-us-west.apache.org> Date: Thu, 13 Jul 2017 22:21:17 +0000 (UTC) archived-at: Thu, 13 Jul 2017 22:21:21 -0000 Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/860#discussion_r124909795 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SorterWrapper.java --- @@ -83,10 +83,9 @@ private SingleBatchSorter newSorter(VectorAccessible batch) { ClassGenerator g = cg.getRoot(); cg.plainJavaCapable(true); // Uncomment out this line to debug the generated code. - cg.saveCodeForDebugging(true); + cg.saveCodeForDebugging(true); --- End diff -- comment out .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---