drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Date Fri, 28 Jul 2017 21:27:11 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r130188600
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
---
    @@ -68,7 +69,7 @@ public void testJaninoClassCompiler() throws Exception {
       @Test
       public void testJDKClassCompiler() throws Exception {
         logger.debug("Testing JDKClassCompiler");
    -    sessionOptions.setOption(OptionValue.createString(OptionType.SESSION, ClassCompilerSelector.JAVA_COMPILER_OPTION,
ClassCompilerSelector.CompilerPolicy.JDK.name()));
    +    sessionOptions.setOption(OptionValue.createString(OptionType.SESSION, ClassCompilerSelector.JAVA_COMPILER_OPTION,
ClassCompilerSelector.CompilerPolicy.JDK.name(), OptionScope.SESSION));
    --- End diff --
    
    Hmmm...
    
    We should not need every caller that sets a session option to say that it is setting a
session option. Instead, the implementation of `setOption` for the session option manager
class should fill in the `OptionScope.SESSION` value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message