drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Date Fri, 28 Jul 2017 21:27:11 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r129928806
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValidator.java
---
    @@ -28,7 +29,7 @@
       // the error messages produced by the validator
       private final String optionName;
       private final boolean isAdminOption;
    -
    +  public static final String ConfigPath = "drill.exec.options.";
    --- End diff --
    
    Java convention is all caps for constants: CONFIG_PATH. Since that name is somewhat generic,
maybe OPTION_DEFAULTS_ROOT or some such.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message