drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #868: DRILL-5547:Linking config options with system optio...
Date Fri, 28 Jul 2017 21:27:10 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/868#discussion_r129928543
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionSet.java
---
    @@ -68,4 +68,14 @@
        * @return the string value
        */
       String getOption(TypeValidators.StringValidator validator);
    +
    +  /**
    +   * Gets the maxwidth value (from the option value) for the given validator.
    +   *
    +   * @param validator the maxwidth validator
    +   * @return the maxwidth value
    +   */
    +  long getOption(TypeValidators.MaxWidthValidator validator);
    --- End diff --
    
    Needed? Can't this work if the MaxWidthValidator is an instance of a long validator?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message