drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #:
Date Fri, 21 Jul 2017 20:15:05 GMT
Github user Ben-Zvi commented on the pull request:

    https://github.com/apache/drill/commit/d30fb247e725665e1b5b0fe9ce2030d8642ced2a#commitcomment-23233113
  
    In exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java:
    In exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
on line 349:
    A minor suggestion: **isRegistrySyncNeeded** is only used here and three lines below.
So possible simplification: Rename it to **isRegistrySyncWithRemoteNeeded**, and remove the
first parameter.  Then __inside__ this method perform the checks for **hasRegistry** and extract
**getRegistryVersion** from the class member **remoteFunctionRegistry** .



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message