drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...
Date Thu, 20 Jul 2017 17:12:37 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r128496657
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -557,7 +556,7 @@ private void readBlockMeta(String path,
         mapper.registerModule(serialModule);
         mapper.registerModule(module);
         mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
    -    FSDataInputStream is = fs.open(p);
    +    FSDataInputStream is = fs.open(path);
    --- End diff --
    
    The stream is closed after performing deserializing ObjectMapper.readValue() [link](https://github.com/apache/drill/blob/9cf6faa7aa834c7ba654ce956c8b523ff3464658/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java#L580).
But try-with-resources is a good way to be sure the stream is closed in case of getting exception
before deserializing.
    Thanks. Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message