drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...
Date Wed, 19 Jul 2017 21:33:47 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r128365742
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
    @@ -82,7 +84,7 @@ private PriorityQueueCopier newCopier(VectorAccessible batch) {
         ClassGenerator<PriorityQueueCopier> g = cg.getRoot();
         cg.plainJavaCapable(true);
         // Uncomment out this line to debug the generated code.
    -//    cg.saveCodeForDebugging(true);
    +    cg.saveCodeForDebugging(true);
    --- End diff --
    
    I guess the fiddle-factor is getting to high; time to implement your suggestion of having
options to enable this stuff. I'll try to add that in some future PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message