drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...
Date Wed, 19 Jul 2017 17:59:52 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r128144906
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java
---
    @@ -26,14 +26,16 @@ public static void allocate(ValueVector v, int valueCount, int bytesPerValue)
{
         allocate(v, valueCount, bytesPerValue, 5);
       }
     
    -  public static void allocatePrecomputedChildCount(ValueVector v, int valueCount, int
bytesPerValue, int childValCount){
    -    if(v instanceof FixedWidthVector) {
    +  public static void allocatePrecomputedChildCount(ValueVector v, int valueCount, int
bytesPerValue, int childValCount) {
    --- End diff --
    
    Well, sure. But, notice that I didn't write this; I only added a space. But, I went ahead
and renamed all the "v"s...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message