drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...
Date Wed, 19 Jul 2017 17:59:47 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java
    @@ -92,8 +93,9 @@ public void setup(final FragmentContext context, final BufferAllocator
        * @return
       public static long memoryNeeded(final int recordCount) {
    -    // We need 4 bytes (SV4) for each record.
    -    return recordCount * 4;
    +    // We need 4 bytes (SV4) for each record, power of 2 rounded.
    --- End diff --
    Actually, this is one of the (few) original method names.
    Good catch on the other method, fixed that one also.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message