drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #874: DRILL-5663: Drillbit fails to start when only keyst...
Date Fri, 14 Jul 2017 19:21:05 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
    @@ -289,30 +297,19 @@ private ServerConnector createHttpsConnector() throws Exception
           final DateTime now = DateTime.now();
           // Create builder for certificate attributes
    -      final X500NameBuilder nameBuilder =
    -          new X500NameBuilder(BCStyle.INSTANCE)
    -              .addRDN(BCStyle.OU, "Apache Drill (auth-generated)")
    -              .addRDN(BCStyle.O, "Apache Software Foundation (auto-generated)")
    -              .addRDN(BCStyle.CN, workManager.getContext().getEndpoint().getAddress());
    +      final X500NameBuilder nameBuilder = new X500NameBuilder(BCStyle.INSTANCE).addRDN(BCStyle.OU,
"Apache Drill (auth-generated)").addRDN(BCStyle.O, "Apache Software Foundation (auto-generated)").addRDN(BCStyle.CN,
    --- End diff --
    Can we keep the previous one-argument-per-line, indented style? Much easier to read.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message