drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #875: DRILL-5671 Set secure ACLs (Access Control List) fo...
Date Fri, 14 Jul 2017 19:08:23 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/875#discussion_r127524590
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -39,6 +39,7 @@
       String ZK_TIMEOUT = "drill.exec.zk.timeout";
       String ZK_ROOT = "drill.exec.zk.root";
       String ZK_REFRESH = "drill.exec.zk.refresh";
    +  String ZK_SECURE_ACL = "drill.exec.zk.use.secure_acl";
    --- End diff --
    
    `use.secure_acl` --> `secure_acl` as `use` is not a group. This provides:
    
    ```
      zk: {
        connect: "localhost:2181",
        root: "drill",
        secure_acl: true,
    ```
    
    Are we using ACL's for security? Then, we are really "applying" ACLs, so maybe `apply_acl`
(apply an access control list...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message