drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #860: DRILL-5601: Rollup of external sort fixes and impro...
Date Fri, 14 Jul 2017 19:07:57 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r127363488
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
    @@ -70,52 +72,90 @@
          */
     
         public final int estSize;
    +
    +    /**
    +     * Number of times the value here (possibly repeated) appears in
    +     * the record batch.
    +     */
    +
         public final int valueCount;
    -    public final int entryCount;
    -    public final int dataSize;
    -    public final int estElementCount;
    +
    +    /**
    +     * Number of times the entries of this column appears. If this is a
    +     * scalar, the entry count is the same as the value count. If this
    --- End diff --
    
    If a scalar, entryCount would be 1 .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message