drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #877: DRILL-5660: Drill 1.10 queries fail due to Parquet ...
Date Fri, 14 Jul 2017 01:00:17 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r127363955
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -557,7 +556,7 @@ private void readBlockMeta(String path,
         mapper.registerModule(serialModule);
         mapper.registerModule(module);
         mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
    -    FSDataInputStream is = fs.open(p);
    +    FSDataInputStream is = fs.open(path);
    --- End diff --
    
    Common practice is to enclose this in a try-with-resources block, assuming that this stream
derives from `AutoCloseable`. Else, we should add our own `try` block and close the file in
`finally`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message